Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477000

Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform

Show all headers | View raw

從我的 iPad 傳送

> David Laight <David.Laight@ACULAB.COM> 於 2016年9月5日 下午9:35 寫道：
> 
> From: Randy Li
>> Sent: 03 September 2016 22:55
> ...
>> +            if (of_device_is_compatible(np, "rockchip,rk3288-usb")
>> +                    && (NULL != hsotg->phy->ops->reset))
>> +                hsotg->phy->ops->reset(hsotg->phy);
>> +
> 
> Is this the only place ops->reset() is called?
Yes.
> Probably much better to check it first.
Sure.
> 
>            if (hsotg->phy->ops->reset
>                    && of_device_is_compatible(np, "rockchip,rk3288-usb")
>                hsotg->phy->ops->reset(hsotg->phy);
I see, if there is no the other review request for this version, I would submit a new version to fix this problem tonight.
> 
>    David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/4] the fix for the USB HOST1 at rk3288 platform Randy Li <ayaka@soulik.info> - 2016-09-04 00:00 +0200
  [PATCH v7 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li <ayaka@soulik.info> - 2016-09-04 00:00 +0200
  [PATCH v7 1/4] phy: Add reset callback Randy Li <ayaka@soulik.info> - 2016-09-04 00:00 +0200
  [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li <ayaka@soulik.info> - 2016-09-04 00:00 +0200
    Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-09-04 00:40 +0200
    RE: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform David Laight <David.Laight@ACULAB.COM> - 2016-09-05 15:50 +0200
      Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Ayaka <ayaka@soulik.info> - 2016-09-06 01:40 +0200
    Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform Kishon Vijay Abraham I <kishon@ti.com> - 2016-09-06 07:20 +0200
      Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform John Youn <John.Youn@synopsys.com> - 2016-09-06 21:00 +0200
        Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Ayaka <ayaka@soulik.info> - 2016-09-07 03:30 +0200
          Re: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in  rk3288 platform John Youn <John.Youn@synopsys.com> - 2016-09-07 04:10 +0200

csiph-web