Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1475439
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 |
| Date | 2016-09-02 22:40 +0200 |
| Message-ID | <sd3pL-4ey-13@gated-at.bofh.it> (permalink) |
| References | <scBWx-3yb-5@gated-at.bofh.it> <scBWx-3yb-29@gated-at.bofh.it> <scHIC-79t-43@gated-at.bofh.it> <scJhn-8ga-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 01 Sep 2016 16:04:57 -0700 "Huang\, Ying" <ying.huang@intel.com> wrote: > >> } > >> > >> -#define SWAPFILE_CLUSTER 256 > >> +#define SWAPFILE_CLUSTER 512 > >> #define LATENCY_LIMIT 256 > >> > > > > What happens to architectures which have different HPAGE_SIZE and/or > > PAGE_SIZE? > > For the architecture with HPAGE_SIZE / PAGE_SIZE == 512 (for example > x86_64), the huge page swap optimizing will be turned on. For other > architectures, it will be turned off as before. > > This mostly because I don't know whether it is a good idea to turn on > THP swap optimizing for the architectures other than x86_64. For > example, it appears that the huge page size is 8M (1<<23) on SPARC. But > I don't know whether 8M is too big for a swap cluster. And it appears > that the huge page size could be as large as 512M on MIPS. This doesn't sounds very organized. If some architecture with some config happens to have HPAGE_SIZE / PAGE_SIZE == 512 then the feature will be turned on; otherwise it will be turned off. Nobody will even notice that it happened. Would it not be better to do #ifdef CONFIG_SOMETHING #define SWAPFILE_CLUSTER (HPAGE_SIZE / PAGE_SIZE) #else #define SWAPFILE_CLUSTER 256 #endif and, by using CONFIG_SOMETHING in the other appropriate places, enable the feature in the usual fashion?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang, Ying" <ying.huang@intel.com> - 2016-09-01 17:20 +0200
Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 Andrew Morton <akpm@linux-foundation.org> - 2016-09-01 23:30 +0200
Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang\, Ying" <ying.huang@intel.com> - 2016-09-02 01:10 +0200
Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 Andrew Morton <akpm@linux-foundation.org> - 2016-09-02 22:40 +0200
Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang\, Ying" <ying.huang@intel.com> - 2016-09-02 22:40 +0200
csiph-web