Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1474657

Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512

From Andrew Morton <akpm@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512
Date 2016-09-01 23:30 +0200
Message-ID <scHIC-79t-43@gated-at.bofh.it> (permalink)
References <scBWx-3yb-5@gated-at.bofh.it> <scBWx-3yb-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu,  1 Sep 2016 08:16:54 -0700 "Huang, Ying" <ying.huang@intel.com> wrote:

> From: Huang Ying <ying.huang@intel.com>
> 
> In this patch, the size of the swap cluster is changed to that of the
> THP (Transparent Huge Page) on x86_64 architecture (512).  This is for
> the THP swap support on x86_64.  Where one swap cluster will be used to
> hold the contents of each THP swapped out.  And some information of the
> swapped out THP (such as compound map count) will be recorded in the
> swap_cluster_info data structure.
> 
> In effect,  this will enlarge swap  cluster size by 2  times.  Which may
> make  it harder  to find  a  free cluster  when the  swap space  becomes
> fragmented.   So  that,  this  may  reduce  the  continuous  swap  space
> allocation and sequential write in theory.  The performance test in 0day
> show no regressions caused by this.
> 
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -196,7 +196,7 @@ static void discard_swap_cluster(struct swap_info_struct *si,
>  	}
>  }
>  
> -#define SWAPFILE_CLUSTER	256
> +#define SWAPFILE_CLUSTER	512
>  #define LATENCY_LIMIT		256
>  

What happens to architectures which have different HPAGE_SIZE and/or
PAGE_SIZE?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang, Ying" <ying.huang@intel.com> - 2016-09-01 17:20 +0200
  Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 Andrew Morton <akpm@linux-foundation.org> - 2016-09-01 23:30 +0200
    Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang\, Ying" <ying.huang@intel.com> - 2016-09-02 01:10 +0200
      Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 Andrew Morton <akpm@linux-foundation.org> - 2016-09-02 22:40 +0200
        Re: [PATCH -v2 01/10] swap: Change SWAPFILE_CLUSTER to 512 "Huang\, Ying" <ying.huang@intel.com> - 2016-09-02 22:40 +0200

csiph-web