Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional
Date	2016-09-02 19:20 +0200
Message-ID	<sd0ie-2iu-23@gated-at.bofh.it> (permalink)
References	<scVse-7Ky-5@gated-at.bofh.it> <scVse-7Ky-25@gated-at.bofh.it> <scY6J-KW-5@gated-at.bofh.it> <scYzM-19Q-23@gated-at.bofh.it> <scZma-1H6-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> What do you think?
>
> I think the probe() needs to fail with a very obvious error message
> saying you need to recompile your kernel with option XYZ enabled in
> order to support this switch, when the optional stuff is not
> optional...

I agree. Does the following snippet looks OK?


    #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2
            if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) {
                    dev_err(chip->dev, "Missing support for Global 2 registers\n");
                    return -EOPNOTSUPP;
            }
    #endif /* CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 */


Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 0/3] net: dsa: mv88e6xxx: isolate Global2 support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 14:10 +0200
  [PATCH net-next 2/3] net: dsa: mv88e6xxx: move Global2 code Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 14:10 +0200
  [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 14:10 +0200
    Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code  optional Andrew Lunn <andrew@lunn.ch> - 2016-09-02 17:00 +0200
      Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 17:30 +0200
        Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code  optional Andrew Lunn <andrew@lunn.ch> - 2016-09-02 18:20 +0200
          Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code  optional Andrew Lunn <andrew@lunn.ch> - 2016-09-02 19:20 +0200
            Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 19:50 +0200
          Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-09-02 19:20 +0200

csiph-web