Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit
Date	2016-09-02 19:20 +0200
Message-ID	<sd0ie-2iu-15@gated-at.bofh.it> (permalink)
References	<sahSh-2Or-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 8/26/2016 1:16 AM, Christophe JAILLET wrote:
> The 2nd parameter of 'find_first_bit' is the number of bits to search.
> In this case, we are passing 'sizeof(tmp)' which is likely to be 4 or 8
> because 'tmp' is an 'unsigned long'.
> 
> It is likely that the number of bits of 'tmp' was expected here. So use
> BITS_PER_LONG instead.

Thanks, applied.


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: 0E572FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/mlx5: Fix a parameter of find_first_bit Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-26 07:30 +0200
  Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit Leon Romanovsky <leonro@mellanox.com> - 2016-08-26 21:40 +0200
  Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit Majd Dibbiny <majd@mellanox.com> - 2016-08-27 12:40 +0200
  Re: [PATCH] IB/mlx5: Fix a parameter of find_first_bit Doug Ledford <dledford@redhat.com> - 2016-09-02 19:20 +0200

csiph-web