Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474291

Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration

Show all headers | View raw

On 09/01/2016 12:59 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Thursday, September 01, 2016 11:21:54 AM Krzysztof Kozlowski wrote:
>> Usage of DTS macros instead of hard-coded numbers makes code easier
>> to read.  One does not have to remember which value means pull-up/down
>> or specific driver strength.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++----------------
>>  1 file changed, 20 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
>> index 527e3193817f..6274359fb323 100644
>> --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
>> +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
>> @@ -8,6 +8,8 @@
>>   * published by the Free Software Foundation.
>>   */
>>  
>> +#include <dt-bindings/pinctrl/samsung.h>
>> +
>>  &pinctrl_0 {
>>  	/*
>>  	 * Pin banks
>> @@ -83,91 +85,91 @@
>>  
>>  	uart0_data: uart0-data {
>>  		samsung,pins = "gph-0", "gph-1";
>> -		samsung,pin-function = <2>;
>> +		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> 
> Shouldn't macros that are also used by s3c* be named as
> SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?

Right, this is the inconsistency. The problem with "samsung" prefix is
that there is no guarantee it will be like that for newer SoCs. How
about one of:
1. using the oldest prefix (S3C24XX in this case),
2. duplicating them per SoC family (so S3C24XX, S3C64XX, EXYNOS).
?

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-09-01 11:30 +0200
  Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 13:10 +0200
    Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-09-01 13:20 +0200
      Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Arnd Bergmann <arnd@arndb.de> - 2016-09-01 13:20 +0200

csiph-web