Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration
Date	2016-09-01 13:20 +0200
Message-ID	<scych-16c-23@gated-at.bofh.it> (permalink)
References	<scwtP-81r-3@gated-at.bofh.it> <scy2C-11X-25@gated-at.bofh.it> <scych-16c-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday, September 1, 2016 1:12:18 PM CEST Krzysztof Kozlowski wrote:
> > 
> > Shouldn't macros that are also used by s3c* be named as
> > SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?
> 
> Right, this is the inconsistency. The problem with "samsung" prefix is
> that there is no guarantee it will be like that for newer SoCs. How
> about one of:
> 1. using the oldest prefix (S3C24XX in this case),
> 2. duplicating them per SoC family (so S3C24XX, S3C64XX, EXYNOS).
> ?

I'd suggest living with the inconsistency and using EXYNOS as the prefix,
as that is the most common one these days, even if the other ones
predate it.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-09-01 11:30 +0200
  Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 13:10 +0200
    Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-09-01 13:20 +0200
      Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration Arnd Bergmann <arnd@arndb.de> - 2016-09-01 13:20 +0200

csiph-web