Re: [PATCH] ASoC: omap-pcm: off-by-one in 'omap_pcm_limit_supported_formats'

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Peter Ujfalusi <peter.ujfalusi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: omap-pcm: off-by-one in 'omap_pcm_limit_supported_formats'
Date	Thu, 01 Sep 2016 09:10:03 +0200
Message-ID	<scuin-5Pb-51@gated-at.bofh.it> (permalink)
References	<scu8F-5sK-21@gated-at.bofh.it>
X-Original-To	Christophe JAILLET <christophe.jaillet@wanadoo.fr>, <jarkko.nikula@bitmer.com>, <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	31
Organization	linux.* mail to news gateway
X-Original-Cc	<alsa-devel@alsa-project.org>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
X-Original-Date	Thu, 1 Sep 2016 09:59:29 +0300
X-Original-Message-ID	<0bb8879b-84d0-f871-7b36-f8c9b4b0b560@ti.com>
X-Original-References	<1472712757-21066-1-git-send-email-christophe.jaillet@wanadoo.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1474113

Show key headers only | View raw

On 09/01/16 09:52, Christophe JAILLET wrote:
> When calling 'snd_pcm_format_physical_width', SNDRV_PCM_FORMAT_LAST is a
> valid value, so don't skip it.

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Un-tested
> ---
>  sound/soc/omap/omap-pcm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index a84f677234f0..94e9ff791f3a 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -58,7 +58,7 @@ static void omap_pcm_limit_supported_formats(void)
>  {
>  	int i;
>  
> -	for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
> +	for (i = 0; i <= SNDRV_PCM_FORMAT_LAST; i++) {
>  		switch (snd_pcm_format_physical_width(i)) {
>  		case 8:
>  		case 16:
> 


-- 
Péter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: omap-pcm: off-by-one in 'omap_pcm_limit_supported_formats' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-09-01 09:00 +0200
  Re: [PATCH] ASoC: omap-pcm: off-by-one in  'omap_pcm_limit_supported_formats' Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-01 09:10 +0200

csiph-web