Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Peter Ujfalusi Newsgroups: linux.kernel Subject: Re: [PATCH] ASoC: omap-pcm: off-by-one in 'omap_pcm_limit_supported_formats' Date: Thu, 01 Sep 2016 09:10:03 +0200 Message-ID: References: X-Original-To: Christophe JAILLET , , , , , User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 31 Organization: linux.* mail to news gateway X-Original-Cc: , , , X-Original-Date: Thu, 1 Sep 2016 09:59:29 +0300 X-Original-Message-ID: <0bb8879b-84d0-f871-7b36-f8c9b4b0b560@ti.com> X-Original-References: <1472712757-21066-1-git-send-email-christophe.jaillet@wanadoo.fr> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1474113 On 09/01/16 09:52, Christophe JAILLET wrote: > When calling 'snd_pcm_format_physical_width', SNDRV_PCM_FORMAT_LAST is a > valid value, so don't skip it. Acked-by: Peter Ujfalusi > Signed-off-by: Christophe JAILLET > --- > Un-tested > --- > sound/soc/omap/omap-pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > index a84f677234f0..94e9ff791f3a 100644 > --- a/sound/soc/omap/omap-pcm.c > +++ b/sound/soc/omap/omap-pcm.c > @@ -58,7 +58,7 @@ static void omap_pcm_limit_supported_formats(void) > { > int i; > > - for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) { > + for (i = 0; i <= SNDRV_PCM_FORMAT_LAST; i++) { > switch (snd_pcm_format_physical_width(i)) { > case 8: > case 16: > -- Péter