Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1474019

Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value

From Reza Arbab <arbab@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value
Date 2016-09-01 04:00 +0200
Message-ID <scpsl-1In-9@gated-at.bofh.it> (permalink)
References (3 earlier) <sckVJ-7wC-35@gated-at.bofh.it> <scngR-sq-3@gated-at.bofh.it> <scnJT-Ri-3@gated-at.bofh.it> <scnTz-UF-1@gated-at.bofh.it> <sco3f-Yp-1@gated-at.bofh.it>
Organization IBM Linux Technology Center

Show all headers | View raw

On Wed, Aug 31, 2016 at 05:28:26PM -0700, David Rientjes wrote:
>> 2. store_mem_state() still needs a tweak, right? It was only 
>> returning -EINVAL by accident, due to the convoluted sequence I 
>> listed in the patch.
>
>Yes, absolutely.  It returning -EINVAL for "nline" is what is accidently
>preserving it's backwards compatibility :)  Note that device_online()
>returns 1 if already online and memory_subsys_online() returns 0 if online
>in this case.  So we want store_mem_state() to return -EINVAL if
>device_online() returns non-zero (this was in my first email).

I'll spin a v3 patch to do this.

Thank you for your review!

-- 
Reza Arbab

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-31 14:30 +0200
  Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 16:40 +0200
    Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-31 17:10 +0200
      [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 17:50 +0200
        Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Andrew Morton <akpm@linux-foundation.org> - 2016-08-31 22:30 +0200
          Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-08-31 23:10 +0200
            Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 01:40 +0200
              Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-09-01 02:10 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 02:20 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-09-01 02:30 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 04:00 +0200
  [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 16:40 +0200

csiph-web