Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473968

Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value

From Reza Arbab <arbab@linux.vnet.ibm.com>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value
Date 2016-09-01 01:40 +0200
Message-ID <scngR-sq-3@gated-at.bofh.it> (permalink)
References <scfjk-40K-55@gated-at.bofh.it> <scfW2-4eb-21@gated-at.bofh.it> <sckiZ-74j-27@gated-at.bofh.it> <sckVJ-7wC-35@gated-at.bofh.it>
Organization IBM Linux Technology Center

Show all headers | View raw

On Wed, Aug 31, 2016 at 02:06:14PM -0700, David Rientjes wrote:
>The correct fix is for store_mem_state() to return -EINVAL when 
>device_online() returns non-zero.

Let me put it to you this way--which one of these sysfs operations is 
behaving correctly?

	# cd /sys/devices/system/memory/memory0
	# cat online
	1
	# echo 1 > online; echo $?
	0

or

	# cd /sys/devices/system/memory/memory0
	# cat state
	online
	# echo online > state; echo $?
	-bash: echo: write error: Invalid argument
	1

One of them should change to match the other.

-- 
Reza Arbab

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-31 14:30 +0200
  Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 16:40 +0200
    Re: [PATCH v2] memory-hotplug: fix store_mem_state() return value Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-31 17:10 +0200
      [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 17:50 +0200
        Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Andrew Morton <akpm@linux-foundation.org> - 2016-08-31 22:30 +0200
          Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-08-31 23:10 +0200
            Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 01:40 +0200
              Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-09-01 02:10 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 02:20 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value David Rientjes <rientjes@google.com> - 2016-09-01 02:30 +0200
                Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return  value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-09-01 04:00 +0200
  [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value Reza Arbab <arbab@linux.vnet.ibm.com> - 2016-08-31 16:40 +0200

csiph-web