Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473894

Re: [PATCH] irda: Fix likely typo in output format string

Show all headers | View raw

On Aug 31, 2016, at 5:31 PM, David Miller wrote:

> From: Oleg Drokin <green@linuxhacker.ru>
> Date: Fri, 26 Aug 2016 23:14:06 -0400
> 
>> %ul would print an unsigned with a letter l at the end which does
>> not seem to be desired here, on the other hand the value being printed
>> is u32 so just drop the l instead of converting to %lu
>> 
>> Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
> 
> %u is for unsigned values, and these are "s32" thus signed.

Hm, you are right.
I could swear I saw them as unsigned when I looked at it.

Anyway can they really be negative? they are seconds and usec,
should I change them to u32 too?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irda: Fix likely typo in output format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-27 05:20 +0200
  Re: [PATCH] irda: Fix likely typo in output format string Joe Perches <joe@perches.com> - 2016-08-27 05:30 +0200
  Re: [PATCH] irda: Fix likely typo in output format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-31 23:40 +0200
    Re: [PATCH] irda: Fix likely typo in output format string David Miller <davem@davemloft.net> - 2016-09-01 00:00 +0200
  Re: [PATCH] irda: Fix likely typo in output format string David Miller <davem@davemloft.net> - 2016-08-31 23:40 +0200

csiph-web