Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1471091

Re: [PATCH] irda: Fix likely typo in output format string

Show all headers | View raw

(added Chunyan Zhang to cc)

On Fri, 2016-08-26 at 23:14 -0400, Oleg Drokin wrote:
> %ul would print an unsigned with a letter l at the end which does
> not seem to be desired here, on the other hand the value being printed
> is u32 so just drop the l instead of converting to %lu

Fixes: 497ec1f2a086 ("irda: vlsi_ir: Replace timeval with ktime_t")

Thanks Oleg

> diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
[]
> @@ -279,7 +279,7 @@ static void vlsi_proc_ndev(struct seq_file *seq, struct net_device *ndev)
>  		(idev->mode==IFF_SIR)?"SIR":((idev->mode==IFF_MIR)?"MIR":"FIR"));
>  	sec = div_s64_rem(ktime_us_delta(ktime_get(), idev->last_rx),
>  			  USEC_PER_SEC, &usec);
> -	seq_printf(seq, "last rx: %ul.%06u sec\n", sec, usec);
> +	seq_printf(seq, "last rx: %u.%06u sec\n", sec, usec);
>  
>  	seq_printf(seq, "RX: packets=%lu / bytes=%lu / errors=%lu / dropped=%lu",
>  		ndev->stats.rx_packets, ndev->stats.rx_bytes, ndev->stats.rx_errors,

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irda: Fix likely typo in output format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-27 05:20 +0200
  Re: [PATCH] irda: Fix likely typo in output format string Joe Perches <joe@perches.com> - 2016-08-27 05:30 +0200
  Re: [PATCH] irda: Fix likely typo in output format string Oleg Drokin <green@linuxhacker.ru> - 2016-08-31 23:40 +0200
    Re: [PATCH] irda: Fix likely typo in output format string David Miller <davem@davemloft.net> - 2016-09-01 00:00 +0200
  Re: [PATCH] irda: Fix likely typo in output format string David Miller <davem@davemloft.net> - 2016-08-31 23:40 +0200

csiph-web