Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1473474

Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

Show all headers | View raw

On Wednesday, August 31, 2016 3:07:00 PM CEST Krzysztof Kozlowski wrote:
> 
> Ok, sounds reasonable. I want to convert also older platforms S3C (drive
> strengths and pull up/down differ) and arm64 SoC: Exynos7. For the
> latter the problem is there is no common place for sharing DTS, except
> the headers. However this does not really belong to headers. I guess
> some level of duplication might be still exist.

We have stuff in the headers that belongs way less there, so I wouldn't
mind, but having a separate set of definitions for arm64 also isn't
a problem at all.
 
> > I think overall, a better solution would have been to define the
> > constants globally (shared with non-exynos) to start with,
> > and have the driver translate generic numbers into vendor
> > specific ones. Obviously it's too late for that now.
> 
> We could extend driver by adding new bindings accepting generic numbers
> (and still backward compatible) but this looks like an overkill.

Agreed, that would only make things more confusing, not less.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] ARM: dts: exynos: Use macros for GPIO to make it more  readable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 6/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos5250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 2/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos3250 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 3/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos4210 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 5/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos4x12 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 4/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos4415 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 7/9] ARM: dts: exynos: Use macros for GPIO configuration on  exynos5260 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
  [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 14:20 +0200
    Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Arnd Bergmann <arnd@arndb.de> - 2016-08-31 14:50 +0200
      Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 15:00 +0200
        Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Arnd Bergmann <arnd@arndb.de> - 2016-08-31 15:10 +0200
          Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-08-31 15:10 +0200
            Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Arnd Bergmann <arnd@arndb.de> - 2016-08-31 15:40 +0200
  Re: [PATCH 0/9] ARM: dts: exynos: Use macros for GPIO to make it more  readable Javier Martinez Canillas <javier@osg.samsung.com> - 2016-08-31 14:50 +0200

csiph-web