Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes

From	Mel Gorman <mgorman@techsingularity.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes
Date	2016-08-31 14:50 +0200
Message-ID	<scd7P-2sm-7@gated-at.bofh.it> (permalink)
References	(4 earlier) <sbSd4-64E-31@gated-at.bofh.it> <sbSPM-6x2-31@gated-at.bofh.it> <sc72p-7cd-3@gated-at.bofh.it> <sc9xf-cp-11@gated-at.bofh.it> <scbz5-1Gy-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 31, 2016 at 01:09:33PM +0200, Michal Hocko wrote:
> > We cannot just convert populated_zone() as many existing users really
> > need to check for present_pages. This patch introduces a managed_zone()
> > helper and uses it in the few cases where it is critical that the check
> > is made for managed pages -- zonelist constuction and page reclaim.
> 
> OK, the patch makes sense to me. I am not happy about two very similar
> functions, to be honest though. managed vs. present checks will be quite
> subtle and it is not entirely clear when to use which one.

In the vast majority of cases, the distinction is irrelevant. The patch
only updates the places where it really matters to minimise any
confusion.

> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks.

> /*
>  * Returns true if a zone has pages managed by the buddy allocator.
>  * All the reclaim decisions have to use this function rather than
>  * populated_zone(). If the whole zone is reserved then we can easily
>  * end up with populated_zone() && !managed_zone().
>  */
> 
> What do you think?
> 

This makes a lot of sense. I've updated the patch and will await a test
from Srikar before reposting.

-- 
Mel Gorman
SUSE Labs

Thread

Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-08-29 11:50 +0200
  Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman <mgorman@techsingularity.net> - 2016-08-30 14:10 +0200
    Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-08-30 16:30 +0200
      Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman <mgorman@techsingularity.net> - 2016-08-30 17:10 +0200
        Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-08-31 08:20 +0200
          Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman <mgorman@techsingularity.net> - 2016-08-31 11:00 +0200
            Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Michal Hocko <mhocko@kernel.org> - 2016-08-31 13:10 +0200
              Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Mel Gorman <mgorman@techsingularity.net> - 2016-08-31 14:50 +0200
            Re: [PATCH 07/34] mm, vmscan: make kswapd reclaim in terms of nodes Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2016-08-31 19:40 +0200

csiph-web