Re: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h systems

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h systems
Date	2016-09-02 10:50 +0200
Message-ID	<scSkF-5B4-29@gated-at.bofh.it> (permalink)
References	<scSkF-5B4-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 31 Aug 2016, Yazen Ghannam wrote:

> The Socket ID is ApicId[bits] on Fam17h systems.
> 
> Change substraction to logical AND when extracting socket_id
> from c->apicid.

So Fam17h will only ever have 2 sockets, right?

Thanks,

	tglx

> Signed-off-by: Yazen Ghannam <Yazen.Ghannam@amd.com>
> ---
>  arch/x86/kernel/cpu/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index f5c69d8..479555f 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -365,7 +365,7 @@ static void amd_detect_cmp(struct cpuinfo_x86 *c)
>  	 if (c->x86 != 0x17 || !cpuid_edx(0x80000006))
>  		return;
>  
> -	socket_id	= (c->apicid >> bits) - 1;
> +	socket_id	= (c->apicid >> bits) & 1;
>  	core_complex_id	= (c->apicid & ((1 << bits) - 1)) >> 3;
>  
>  	per_cpu(cpu_llc_id, cpu) = (socket_id << 3) | core_complex_id;
> -- 
> 1.9.1
> 
>

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h  systems Thomas Gleixner <tglx@linutronix.de> - 2016-09-02 10:50 +0200
  RE: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h  systems "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2016-09-02 15:00 +0200
    RE: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h  systems Thomas Gleixner <tglx@linutronix.de> - 2016-09-02 15:20 +0200
      RE: [PATCH] x86/AMD: Fix Socket ID for LLC topology for AMD Fam17h  systems "Ghannam, Yazen" <Yazen.Ghannam@amd.com> - 2016-09-02 20:10 +0200

csiph-web