Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1474519
| From | Krzysztof Kozlowski <krzk@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version |
| Date | 2016-09-01 18:20 +0200 |
| Message-ID | <scCSB-47A-1@gated-at.bofh.it> (permalink) |
| References | <sbLuV-1Hg-29@gated-at.bofh.it> <scdhv-2vG-13@gated-at.bofh.it> <sczUJ-2jO-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 01, 2016 at 03:03:51PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, August 31, 2016 08:58:27 PM Randy Li wrote:
> > The TOPEET itop is a samsung exnynos 4412 core board, which have
> > two package versions. This patch add the support for SCP version.
> >
> > Currently supported are USB3503A HSIC, USB OTG, eMMC, rtc and
> > PMIC. The future features are in the based board. Also MFC and
> > watchdog have been enabled.
> >
> > Signed-off-by: Randy Li <ayaka@soulik.info>
> > ---
> > arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi | 490 ++++++++++++++++++++++++
> > 1 file changed, 490 insertions(+)
> > create mode 100644 arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
>
> [...]
>
> > + s5m8767_osc: clocks {
>
> Don't you also need:
>
> compatible = "samsung,s5m8767-clk";
>
> here?
No specific need... It is confusing but it is the same as with
regulators. The parent MFD driver creates children devices and match
drivers. The children (e.g. clk or regulator driver) look for hard-coded
subnode - clocks/regulators.
The compatible is actually not used in current form.
> BTW Does anyone know why there are no users of
> "samsung,s2mps11-clk" compatible in the tree
> (commit 53c31b3437a6400c6ffc2c9315680217ad84cb6d
> "mfd: sec-core: Add of_compatible strings for
> clock MFD cells" added it in March 2014)?
That is partially my fault. I got convinced by Lee Jones to add
compatibles even there are no users of them. The compatibles could be
added - for Arndale Octa and XU3/XU4. I think the only benefit of that
would be attaching the clock driver to the of_node.
Best regards,
Krzysztof
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Randy Li <ayaka@soulik.info> - 2016-08-28 13:30 +0200
[PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version Randy Li <ayaka@soulik.info> - 2016-08-28 13:30 +0200
Re: [PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> - 2016-08-28 23:20 +0200
Re: [PATCH 1/4] ARM: dts: Add TOPEET itop core board SCP package version Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-30 09:20 +0200
[RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Randy Li <ayaka@soulik.info> - 2016-08-31 15:00 +0200
Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-31 20:50 +0200
Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Ayaka <ayaka@soulik.info> - 2016-08-31 22:00 +0200
Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2016-09-01 15:10 +0200
Re: [RESEND PATCH 1/3] ARM: dts: Add TOPEET itop core board SCP package version Krzysztof Kozlowski <krzk@kernel.org> - 2016-09-01 18:20 +0200
[PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop Elite board Randy Li <ayaka@soulik.info> - 2016-08-28 13:30 +0200
Re: [PATCH 3/4] ARM: dts: add fimc support in exynos4412 TOPEET iTop Elite board Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-30 09:40 +0200
[PATCH 3/3 v3] devicetree: bindings: Add vendor prefix for Topeet. Randy Li <ayaka@soulik.info> - 2016-08-31 15:10 +0200
Re: [PATCH 0/4 v3] Add a new board TOPEET iTOP for exynos 4412 Krzysztof Kozlowski <krzk@kernel.org> - 2016-08-30 09:10 +0200
csiph-web