Re: [PATCH] ravb: avoid unused function warnings

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ravb: avoid unused function warnings
Date	2016-08-31 08:40 +0200
Message-ID	<sc7lL-7js-3@gated-at.bofh.it> (permalink)
References	<saroC-ua-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 26 Aug 2016 17:30:29 +0200

> When CONFIG_PM_SLEEP is disabled, we get a couple of harmless warnings:
> 
> drivers/net/ethernet/renesas/ravb_main.c:2117:12: error: 'ravb_resume' defined but not used [-Werror=unused-function]
> drivers/net/ethernet/renesas/ravb_main.c:2104:12: error: 'ravb_suspend' defined but not used [-Werror=unused-function]
> 
> The simplest solution here is to replace the #ifdef with __maybe_unused
> annotations, which lets the compiler do the right thing by itself.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ravb: avoid unused function warnings Arnd Bergmann <arnd@arndb.de> - 2016-08-26 17:40 +0200
  Re: [PATCH] ravb: avoid unused function warnings Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-27 00:50 +0200
    Re: [PATCH] ravb: avoid unused function warnings Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-08-27 23:50 +0200
  Re: [PATCH] ravb: avoid unused function warnings David Miller <davem@davemloft.net> - 2016-08-31 08:40 +0200

csiph-web