Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472600

Re: [PATCH v4] brcmfmac: add missing header dependencies

Show all headers | View raw

Baoyou Xie <baoyou.xie@linaro.org> writes:

> On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@gmail.com> wrote:
>
>     On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@linaro.org> wrote:
>     > We get 1 warning when build kernel with W=1:
>     > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
>     warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
>     building? I'm not native English, but I think so.
>    
>
>     > In fact, this function is declared in brcmfmac/debug.h, so this patch
>     > add missing header dependencies.
>
>     adds
>    
>
>     > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>     > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
>     Please don't resend patches just to add tags like that. This only
>     increases a noise and patchwork handles this just fine, see:
>     https://patchwork.kernel.org/patch/9303285/
>     https://patchwork.kernel.org/patch/9303285/mbox/
>
>
> Do I need to resend a patch that fixes two typos(build/add)? or you modify them
> on your way?

I can fix those when I commit the patch.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] brcmfmac: add missing header dependencies Baoyou Xie <baoyou.xie@linaro.org> - 2016-08-29 14:50 +0200
  Re: [PATCH v4] brcmfmac: add missing header dependencies Rafał Miłecki <zajec5@gmail.com> - 2016-08-29 17:40 +0200
    Re: [PATCH v4] brcmfmac: add missing header dependencies Rafał Miłecki <zajec5@gmail.com> - 2016-08-29 18:50 +0200
    Re: [PATCH v4] brcmfmac: add missing header dependencies Kalle Valo <kvalo@codeaurora.org> - 2016-08-30 18:10 +0200
  Re: [v4] brcmfmac: add missing header dependencies Kalle Valo <kvalo@codeaurora.org> - 2016-09-03 12:20 +0200

csiph-web