Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1472410

Re: [PATCH] generic: Add the exception case checking routine for ppi interrupt

Show all headers | View raw

+Mark

On 30/08/16 11:35, majun (F) wrote:
> 
> 
> 在 2016/8/30 16:50, Marc Zyngier 写道:
>> On 30/08/16 05:17, MaJun wrote:
>>> From: Ma Jun <majun258@huawei.com>
>>>
>>> During system booting, if the interrupt which has no action registered
>>> is triggered, it would cause system panic when try to access the
>>> action member.
>>
>> And why would that interrupt be enabled? If you enable a PPI before
>> registering a handler, you're doing something wrong.
>>
> 
> Actually,the problem described above happened during the capture
> kernel booting.
> 
> In my system, sometimes there is a pending physical timer
> interrupt(30) when the first kernel panic and the status is kept
> until the capture kernel booting.

And that's perfectly fine. The interrupt can be pending forever, as it
shouldn't get enabled.

> So, this interrupt will be handled during capture kernel booting.

Why? Who enables it?

> 
> Becasue we use virt timer interrupt but not physical timer interrupt
> in capture kernel, the interrupt 30 has no action handler.

Again: who enables this interrupt? Whichever driver enables it should be
fixed.

> Besides, I think we need to do exception check in this function just
> like "handle_fasteoi_irq" does.

I respectfully disagree. This will only hide a whole class of silly
bugs, and I'd rather squash them instead of papering over them.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] generic: Add the exception case checking routine for ppi interrupt MaJun <majun258@huawei.com> - 2016-08-30 06:20 +0200
  Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Marc Zyngier <marc.zyngier@arm.com> - 2016-08-30 11:00 +0200
    Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt "majun (F)" <majun258@huawei.com> - 2016-08-30 12:40 +0200
      Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Marc Zyngier <marc.zyngier@arm.com> - 2016-08-30 13:10 +0200
        Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Mark Rutland <mark.rutland@arm.com> - 2016-08-30 13:30 +0200
          Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt "majun (F)" <majun258@huawei.com> - 2016-08-31 08:40 +0200
            Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Marc Zyngier <marc.zyngier@arm.com> - 2016-08-31 10:40 +0200
              Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt "majun (F)" <majun258@huawei.com> - 2016-09-01 10:20 +0200
                Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Marc Zyngier <marc.zyngier@arm.com> - 2016-09-01 11:10 +0200
                Re: [PATCH] generic: Add the exception case checking routine for  ppi interrupt Thomas Gleixner <tglx@linutronix.de> - 2016-09-02 15:20 +0200
                Re: [PATCH] generic: Add the exception case checking routine for ppi  interrupt Marc Zyngier <marc.zyngier@arm.com> - 2016-09-02 17:50 +0200
                [tip:irq/core] genirq: Robustify handle_percpu_devid_irq() tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2016-09-02 18:20 +0200

csiph-web