Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show

From	hejianet <hejianet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show
Date	2016-08-30 10:20 +0200
Message-ID	<sbMqZ-2gM-7@gated-at.bofh.it> (permalink)
References	<sbxih-10O-9@gated-at.bofh.it> <sbxii-10O-33@gated-at.bofh.it> <sbxUZ-1fP-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Eric


On 8/30/16 12:41 AM, Eric Dumazet wrote:
> On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote:
>> This patch exchanges the two loop for collecting the percpu statistics
>> data. This can aggregate the data by going through all the items of each
>> cpu sequentially. In snmp_seq_show, just use one buff copy to dislay the
>> Udp and UdpLite data because they are the same.
> This is obviously not true.
>
> On my laptop it seems it handled no UdpLite frames, but got plenty of
> Udp ones.
>
> $ grep Udp /proc/net/snmp
> Udp: InDatagrams NoPorts InErrors OutDatagrams RcvbufErrors SndbufErrors InCsumErrors
> Udp: 1555889 108318 0 3740780 0 0 0
> UdpLite: InDatagrams NoPorts InErrors OutDatagrams RcvbufErrors SndbufErrors InCsumErrors
> UdpLite: 0 0 0 0 0 0 0
Thanks, you are right. I misunderstand the comments of source codes.
Will resend it

B.R.
Jia
>
>
>
> .
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show Jia He <hejianet@gmail.com> - 2016-08-29 18:10 +0200
  Re: [RFC PATCH 1/6] proc: Reduce cache miss in  {snmp,netstat}_seq_show Eric Dumazet <eric.dumazet@gmail.com> - 2016-08-29 18:50 +0200
    Re: [RFC PATCH 1/6] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-08-30 10:20 +0200

csiph-web