Re: [PATCH] bluetooth, regression: MSG_TRUNC fixes

From	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] bluetooth, regression: MSG_TRUNC fixes
Date	2016-08-30 10:30 +0200
Message-ID	<sbMAF-2mW-15@gated-at.bofh.it> (permalink)
References	<sbMAF-2mW-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Mika,

On Wed, Aug 24, 2016 at 1:13 PM, Mika Penttilä
<mika.penttila@nextfour.com> wrote:
> Recent 4.8-rc changes to bluetooth MSG_TRUNC handling introduced regression; pairing finishes
> but connecting profiles not.
>
> With the below fixes to MSG_TRUNC handling the connection is established normally.
>
> --Mika
>
>
> Signed-off-by: Mika Penttilä <mika.penttila@nextfour.com>
> ---
>
> diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
> index ece45e0..0b5f729 100644
> --- a/net/bluetooth/af_bluetooth.c
> +++ b/net/bluetooth/af_bluetooth.c
> @@ -250,7 +250,7 @@ int bt_sock_recvmsg(struct socket *sock, struct msghdr *msg, siz
>
>         skb_free_datagram(sk, skb);
>
> -       if (msg->msg_flags & MSG_TRUNC)
> +       if (flags & MSG_TRUNC)
>                 copied = skblen;
>
>         return err ? : copied;
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
> index 6ef8a01..96f04b7 100644
> --- a/net/bluetooth/hci_sock.c
> +++ b/net/bluetooth/hci_sock.c
> @@ -1091,7 +1091,7 @@ static int hci_sock_recvmsg(struct socket *sock, struct msghdr
>
>         skb_free_datagram(sk, skb);
>
> -       if (msg->msg_flags & MSG_TRUNC)
> +       if (flags & MSG_TRUNC)
>                 copied = skblen;
>
>         return err ? : copied;
> --

I believe similar patches already went to bluetooth-next so it should
be in the way if not already merged.

-- 
Luiz Augusto von Dentz

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] bluetooth, regression: MSG_TRUNC fixes Luiz Augusto von Dentz <luiz.dentz@gmail.com> - 2016-08-30 10:30 +0200

csiph-web