Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470702

[PATCH 6/8] cris-cryptocop: Delete two variables in cryptocop_ioctl_process()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 26 Aug 2016 13:40:29 +0200

A zero was assigned to the local variables "cipher_done" and "csum_done"
at one place. But they were not read within this function.
Thus remove them.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/cris/arch-v32/drivers/cryptocop.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
index cd34723..a682b1f 100644
--- a/arch/cris/arch-v32/drivers/cryptocop.c
+++ b/arch/cris/arch-v32/drivers/cryptocop.c
@@ -2497,8 +2497,6 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 	int    cipher_active, digest_active, csum_active;
 	int    end_digest, end_csum;
 	int    digest_done = 0;
-	int    cipher_done = 0;
-	int    csum_done = 0;
 
 	DEBUG(printk("cryptocop_ioctl_process\n"));
 
@@ -2794,12 +2792,10 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 			dcfgs[dcfg_ix].src = cryptocop_source_dma;
 			cipher_active = 1;
 
-			if (next_ix == (oper.cipher_start + oper.cipher_len)){
-				cipher_done = 1;
+			if (next_ix == (oper.cipher_start + oper.cipher_len))
 				dcfgs[dcfg_ix].last = 1;
-			} else {
+			else
 				dcfgs[dcfg_ix].last = 0;
-			}
 			dcfgs[dcfg_ix].next = descs[desc_ix].cfg;
 			descs[desc_ix].cfg = &dcfgs[dcfg_ix];
 			++dcfg_ix;
@@ -2823,12 +2819,10 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 			csum_active = 1;
 			dcfgs[dcfg_ix].tid = CRYPTOCOP_IOCTL_CSUM_TID;
 			dcfgs[dcfg_ix].src = cryptocop_source_dma;
-			if (next_ix == (oper.csum_start + oper.csum_len)){
-				csum_done = 1;
+			if (next_ix == (oper.csum_start + oper.csum_len))
 				dcfgs[dcfg_ix].last = 1;
-			} else {
+			else
 				dcfgs[dcfg_ix].last = 0;
-			}
 			dcfgs[dcfg_ix].next = descs[desc_ix].cfg;
 			descs[desc_ix].cfg = &dcfgs[dcfg_ix];
 			++dcfg_ix;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] cris-cryptocop: Fine-tuning for some function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 3/8] cris-cryptocop: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 7/8] cris-cryptocop: Delete unnecessary variable  initialisations in cryptocop_ioctl_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 4/8] cris-cryptocop: Less function calls in  cryptocop_ioctl_process() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 6/8] cris-cryptocop: Delete two variables in  cryptocop_ioctl_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 2/8] cris-cryptocop: Improve determination of sizes in five  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:10 +0200
    Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" Julia Lawall <julia.lawall@lip6.fr> - 2016-08-27 21:10 +0200
      Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 09:20 +0200
        Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" Julia Lawall <julia.lawall@lip6.fr> - 2016-08-28 12:30 +0200
          Re: cris-cryptocop: Apply another recommendation from "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 15:30 +0200

csiph-web