Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1470696

[PATCH 7/8] cris-cryptocop: Delete unnecessary variable initialisations in cryptocop_ioctl_process()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 26 Aug 2016 13:57:21 +0200

Nine local variables will be set to an appropriate value a bit later.
Thus omit the explicit initialisation which became unnecessary with
a previous update step.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/cris/arch-v32/drivers/cryptocop.c | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
index a682b1f..1a966dc 100644
--- a/arch/cris/arch-v32/drivers/cryptocop.c
+++ b/arch/cris/arch-v32/drivers/cryptocop.c
@@ -2461,14 +2461,12 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 	struct cryptocop_private        *dev = filp->private_data;
 	struct strcop_crypto_op         *crp_oper = (struct strcop_crypto_op *)arg;
 	struct strcop_crypto_op         oper = {0};
-	int                             err = 0;
-	struct cryptocop_operation      *cop = NULL;
-
-	struct ioctl_job_cb_ctx         *jc = NULL;
-
-	struct page                     **inpages = NULL;
+	int                             err;
+	struct cryptocop_operation      *cop;
+	struct ioctl_job_cb_ctx         *jc;
+	struct page                     **inpages;
 	struct page                     **outpages = NULL;
-	int                             noinpages = 0;
+	int                             noinpages;
 	int                             nooutpages;
 
 	struct cryptocop_desc           descs[5]; /* Max 5 descriptors are needed, there are three transforms that
@@ -2482,16 +2480,14 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig
 
 	unsigned char                   *digest_result = NULL;
 	int                             digest_length = 0;
-	int                             cblocklen = 0;
+	int                             cblocklen;
 	unsigned char                   csum_result[CSUM_BLOCK_LENGTH];
 	struct cryptocop_session        *sess;
-
-	int    iovlen = 0;
+	int    iovlen;
 	int    iovix = 0;
 	int    pageix = 0;
-	int    pageoffset = 0;
-
-	size_t prev_ix = 0;
+	int    pageoffset;
+	size_t prev_ix;
 	size_t next_ix;
 
 	int    cipher_active, digest_active, csum_active;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] cris-cryptocop: Fine-tuning for some function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 3/8] cris-cryptocop: Delete unnecessary braces SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 7/8] cris-cryptocop: Delete unnecessary variable  initialisations in cryptocop_ioctl_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 4/8] cris-cryptocop: Less function calls in  cryptocop_ioctl_process() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 6/8] cris-cryptocop: Delete two variables in  cryptocop_ioctl_process() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 2/8] cris-cryptocop: Improve determination of sizes in five  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:00 +0200
  [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-26 15:10 +0200
    Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" Julia Lawall <julia.lawall@lip6.fr> - 2016-08-27 21:10 +0200
      Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 09:20 +0200
        Re: [PATCH 8/8] cris-cryptocop: Apply another recommendation from  "checkpatch.pl" Julia Lawall <julia.lawall@lip6.fr> - 2016-08-28 12:30 +0200
          Re: cris-cryptocop: Apply another recommendation from "checkpatch.pl" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-28 15:30 +0200

csiph-web