Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1470492

Re: [PATCH v2] net: macb: Increase DMA TX buffer size

From David Miller <davem@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] net: macb: Increase DMA TX buffer size
Date 2016-08-26 02:20 +0200
Message-ID <sad2h-888-9@gated-at.bofh.it> (permalink)
References <s9LSp-6Bj-3@gated-at.bofh.it> <s9PMm-17y-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Xander Huff <xander.huff@ni.com>
Date: Wed, 24 Aug 2016 17:25:39 -0500

> From: Nathan Sullivan <nathan.sullivan@ni.com>
> 
> In recent testing with the RT patchset, we have seen cases where the
> transmit ring can fill even with up to 200 txbds in the ring. Increase the
> size of the DMA TX ring to avoid overruns.
> 
> Signed-off-by: Xander Huff <xander.huff@ni.com>
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>

This is really a short term solution.

While a larger TX ring may help RT, it's wasteful to have a ring that
large on non-RT.  Both uses are valid.

Therefore what really needs to happen is to make this driver support
changing the RX and TX ring sizes at runtime via ethtool just like
pretty much every other driver.

THanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] net: macb: Increase DMA buffer size Xander Huff <xander.huff@ni.com> - 2016-08-24 21:00 +0200
  Re: [PATCH] net: macb: Increase DMA buffer size Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-08-24 21:20 +0200
    [PATCH v2] net: macb: Increase DMA TX buffer size Xander Huff <xander.huff@ni.com> - 2016-08-25 01:30 +0200
      Re: [PATCH v2] net: macb: Increase DMA TX buffer size David Miller <davem@redhat.com> - 2016-08-26 02:20 +0200

csiph-web