Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470491
| From | Alexey Khoroshilov <khoroshilov@ispras.ru> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] usb: gadget: goku_udc: fix memory leak in goku_probe() |
| Date | 2016-08-26 02:20 +0200 |
| Message-ID | <sad2h-888-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Memory allocated for goku_udc device is not deallocated at error paths in goku_probe(), because gadget_release() destructor is not registered yet. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- drivers/usb/gadget/udc/goku_udc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index d2205d9e0c8b..8b290c128d97 100644 --- a/drivers/usb/gadget/udc/goku_udc.c +++ b/drivers/usb/gadget/udc/goku_udc.c @@ -1839,6 +1839,8 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id) err: if (dev) goku_remove (pdev); + /* gadget_release is not registered yet, kfree explicitly */ + kfree(dev); return retval; } -- 2.7.4
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] usb: gadget: goku_udc: fix memory leak in goku_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-08-26 02:20 +0200
csiph-web