Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support
Date	2016-08-26 00:40 +0200
Message-ID	<sabtw-768-31@gated-at.bofh.it> (permalink)
References	<s4VfH-2u4-7@gated-at.bofh.it> <s4VfI-2u4-33@gated-at.bofh.it> <sa98l-5HC-21@gated-at.bofh.it> <sa9UJ-619-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > You could have left the original 'return' instead of the 2 new ones, but
> > you decide.
> 
> Yes I know, but I wanted to ensure for runtime-pm we only return 0 on
> success. Yes clk_enable should only return 0 on success and a negative
> error code otherwise, but I prefer this. So will leave as-is.

OK.

> 
> >> -	if (tegra_i2c_flush_fifos(i2c_dev))
> >> -		err = -ETIMEDOUT;
> >> +	err = tegra_i2c_flush_fifos(i2c_dev);
> > 
> > 'err' is assigned but where is it checked?
> 
> It will be returned by the function. This is no different to how it
> works today if you look at the code. I did think about checking it right

I agree. I missed it before, thanks for the heads up.

Thread

[PATCH 0/6] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
  [PATCH 6/6] i2c: tegra: Add pinctrl support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
    Re: [PATCH 6/6] i2c: tegra: Add pinctrl support Laxman Dewangan <ldewangan@nvidia.com> - 2016-08-11 17:20 +0200
  [PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
    Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 21:40 +0200
      Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 00:20 +0200
  [PATCH 1/6] i2c: tegra: Add missing new line characters Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
  [PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
    Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 22:10 +0200
      Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter <jonathanh@nvidia.com> - 2016-08-25 23:00 +0200
        Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Wolfram Sang <wsa@the-dreams.de> - 2016-08-26 00:40 +0200
  [PATCH 3/6] i2c: tegra: Use device name for adapter name Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
  Re: [PATCH 0/6] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-24 13:20 +0200

csiph-web