Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470374
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support |
| Date | 2016-08-25 22:10 +0200 |
| Message-ID | <sa98l-5HC-21@gated-at.bofh.it> (permalink) |
| References | <s4VfH-2u4-7@gated-at.bofh.it> <s4VfI-2u4-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
> @@ -407,32 +410,39 @@ static inline int tegra_i2c_clock_enable(struct tegra_i2c_dev *i2c_dev)
> return ret;
> }
> }
> +
> ret = clk_enable(i2c_dev->div_clk);
> if (ret < 0) {
> dev_err(i2c_dev->dev,
> "Enabling div clk failed, err %d\n", ret);
> clk_disable(i2c_dev->fast_clk);
> + return ret;
> }
> - return ret;
> +
> + return 0;
You could have left the original 'return' instead of the 2 new ones, but
you decide.
> - if (tegra_i2c_flush_fifos(i2c_dev))
> - err = -ETIMEDOUT;
> + err = tegra_i2c_flush_fifos(i2c_dev);
'err' is assigned but where is it checked?
I'll apply patches 1-4 meanwhile.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
[PATCH 6/6] i2c: tegra: Add pinctrl support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
Re: [PATCH 6/6] i2c: tegra: Add pinctrl support Laxman Dewangan <ldewangan@nvidia.com> - 2016-08-11 17:20 +0200
[PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 21:40 +0200
Re: [PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter <jonathanh@nvidia.com> - 2016-08-26 00:20 +0200
[PATCH 1/6] i2c: tegra: Add missing new line characters Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
[PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Wolfram Sang <wsa@the-dreams.de> - 2016-08-25 22:10 +0200
Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter <jonathanh@nvidia.com> - 2016-08-25 23:00 +0200
Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support Wolfram Sang <wsa@the-dreams.de> - 2016-08-26 00:40 +0200
[PATCH 3/6] i2c: tegra: Use device name for adapter name Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:20 +0200
Re: [PATCH 0/6] Some Tegra I2C Updates Jon Hunter <jonathanh@nvidia.com> - 2016-08-24 13:20 +0200
csiph-web