Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470198
| From | Mark Hounschell <markh@compro.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open |
| Date | 2016-08-25 17:00 +0200 |
| Message-ID | <sa4il-2hA-9@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <s9Gzp-2Q5-51@gated-at.bofh.it> <s9MY9-7ov-3@gated-at.bofh.it> <s9NKx-7XX-11@gated-at.bofh.it> <sa2zT-1n5-19@gated-at.bofh.it> <sa4il-2hA-11@gated-at.bofh.it> |
| Organization | Compro Computer Svcs. |
On 08/25/2016 10:41 AM, Jens Axboe wrote: > On 08/25/2016 07:08 AM, Mark Hounschell wrote: >> On 08/24/2016 05:11 PM, Jiri Kosina wrote: >>> On Wed, 24 Aug 2016, Greg Kroah-Hartman wrote: >>> >>>>> I have a problem with this patch. It only fixes one of the regressions >>>>> caused by the original change to the floppy driver. It does not >>>>> address the >>>>> user land breakage of removing the NODELAY flag checks. >>>> >>>> Does the same problem also happen in Linus's tree? If not, any >>>> hints on >>>> the patch that might have fixed it there? >>> >> >> Yes, it does. IMHO the entire patch (between 4.4 and 4.5 that broke user >> land multiple ways) should be reverted and a fix for what ever obscure >> BUG was supposed to be fixed should be "retried". >> >>> That's still an unresolved issue, and it's on my list to things to look >>> into. >>> >>> This particular patch though fixes a different issue, and should be >>> applied to -stable. >>> >> >> This patch fixes a bug that was introduced to fix "some other obscure >> BUG" that has nothing to do whatever with the "physical floppy" device. >> And it broke user land in at least 2 ways. All this patch does is revert >> part of the original patch so that it is only broke in 1 way to user >> land. It should revert the whole thing IMHO. > > Which patch is this? If that is truly the case, it should be reverted > asap. > commit 09954bad448791ef01202351d437abdd9497a804 seems to be the one. Mark
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-18 16:30 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Mark Hounschell <markh@compro.net> - 2016-08-24 15:40 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-24 22:30 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina <jikos@kernel.org> - 2016-08-24 23:20 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Mark Hounschell <markh@compro.net> - 2016-08-25 15:10 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Mark Hounschell <markh@compro.net> - 2016-08-25 17:00 +0200
Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina <jikos@kernel.org> - 2016-08-25 17:20 +0200
csiph-web