Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open
Date	2016-08-25 17:20 +0200
Message-ID	<sa4BI-2Is-27@gated-at.bofh.it> (permalink)
References	(2 earlier) <s9Gzp-2Q5-51@gated-at.bofh.it> <s9MY9-7ov-3@gated-at.bofh.it> <s9NKx-7XX-11@gated-at.bofh.it> <sa2zT-1n5-19@gated-at.bofh.it> <sa4il-2hA-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 25 Aug 2016, Jens Axboe wrote:

> Which patch is this? If that is truly the case, it should be reverted 
> asap.

I've been looking into this for the past few days, and unfortunately I am 
not able to come up with a simple fix, so revert seems like the way to go.

Unfortunately, by reverting the patch, we'll get back into the original 
situation, where the bug found by syzkaller would be present.

If going down the revert path, we'd have to bring the driver to the state 
it was before, i.e. reverting it and the followup fix, i.e.

	ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e
	09954bad448791ef01202351d437abdd9497a804

And then go back to the drawing board to fix the corruption reported by 
syzkaller.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only open Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-18 16:30 +0200
  Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Mark Hounschell <markh@compro.net> - 2016-08-24 15:40 +0200
    Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-24 22:30 +0200
      Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Jiri Kosina <jikos@kernel.org> - 2016-08-24 23:20 +0200
        Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Mark Hounschell <markh@compro.net> - 2016-08-25 15:10 +0200
          Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Mark Hounschell <markh@compro.net> - 2016-08-25 17:00 +0200
          Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only  open Jiri Kosina <jikos@kernel.org> - 2016-08-25 17:20 +0200

csiph-web