Re: [PATCH V2] audit: log 32-bit socketcalls

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Paris <eparis@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] audit: log 32-bit socketcalls
Date	Fri, 13 Jan 2017 16:20:02 +0100
Message-ID	<sZbO2-2sy-31@gated-at.bofh.it> (permalink)
References	<sZ6Or-7I1-33@gated-at.bofh.it> <sZbl0-23t-35@gated-at.bofh.it> <sZbEo-2pl-59@gated-at.bofh.it>
X-Original-To	Richard Guy Briggs <rgb@redhat.com>
Content-Type	text/plain; charset="UTF-8"
MIME-Version	1.0
Content-Transfer-Encoding	8bit
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 13 Jan 2017 15:18:25 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-audit@redhat.com, Kangkook Jee <aixer77@gmail.com>, Paul Moore <pmoore@redhat.com>, Steve Grubb <sgrubb@redhat.com>
X-Original-Date	Fri, 13 Jan 2017 10:18:22 -0500
X-Original-Message-ID	<1484320702.5300.8.camel@redhat.com>
X-Original-References	<dd937da01da72da9277e44ed79abd1f4618c14c5.1484297765.git.rgb@redhat.com> <1484318543.5300.1.camel@redhat.com> <20170113150637.GB3087@madcap2.tricolour.ca>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1558468

Show key headers only | View raw

On Fri, 2017-01-13 at 10:06 -0500, Richard Guy Briggs wrote:
> On 2017-01-13 09:42, Eric Paris wrote:
> > On Fri, 2017-01-13 at 04:51 -0500, Richard Guy Briggs wrote:


> > > diff --git a/include/linux/audit.h b/include/linux/audit.h
> > > index 9d4443f..43d8003 100644
> > > --- a/include/linux/audit.h
> > > +++ b/include/linux/audit.h
> > > @@ -387,6 +387,18 @@ static inline int audit_socketcall(int
> > > nargs,
> > > unsigned long *args)
> > >  		return __audit_socketcall(nargs, args);
> > >  	return 0;
> > >  }
> > > +static inline int audit_socketcall_compat(int nargs, u32 *args)
> > > +{
> > > +	if (unlikely(!audit_dummy_context())) {
> > 
> > I've always hated these likely/unlikely. Mostly because I think
> > they
> > are so often wrong. I believe this says that you compiled audit in
> > but
> > you expect it to be explicitly disabled. While that is (recently)
> > true
> > in Fedora I highly doubt that's true on the vast majority of
> > systems
> > that have audit compiled in.
> 
> It has been argued that audit should have pretty much no performance
> impact if it is not in use and that if it is, we're willing to take
> the
> more significant overhead of the rest of the code for the sake of one
> test to determine whether or not to follow this code path.

Ok, I can buy that argument. Not sure its where I would have settled,
but it does make sense. I'll obviously defer to Paul on what he wants
out of style. I always assume the compiler is brilliant and write
stupid code but your logic is sound there too.

You can/should pretend I said nothing.

Thread

[PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 11:00 +0100
  Re: [PATCH V2] audit: log 32-bit socketcalls Eric Paris <eparis@redhat.com> - 2017-01-13 15:50 +0100
    Re: [PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 16:10 +0100
      Re: [PATCH V2] audit: log 32-bit socketcalls Eric Paris <eparis@redhat.com> - 2017-01-13 16:20 +0100
        Re: [PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 16:30 +0100
  Re: [PATCH V2] audit: log 32-bit socketcalls David Miller <davem@davemloft.net> - 2017-01-16 19:40 +0100

csiph-web