Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558468

Re: [PATCH V2] audit: log 32-bit socketcalls

Show all headers | View raw

On Fri, 2017-01-13 at 10:06 -0500, Richard Guy Briggs wrote:
> On 2017-01-13 09:42, Eric Paris wrote:
> > On Fri, 2017-01-13 at 04:51 -0500, Richard Guy Briggs wrote:


> > > diff --git a/include/linux/audit.h b/include/linux/audit.h
> > > index 9d4443f..43d8003 100644
> > > --- a/include/linux/audit.h
> > > +++ b/include/linux/audit.h
> > > @@ -387,6 +387,18 @@ static inline int audit_socketcall(int
> > > nargs,
> > > unsigned long *args)
> > >  		return __audit_socketcall(nargs, args);
> > >  	return 0;
> > >  }
> > > +static inline int audit_socketcall_compat(int nargs, u32 *args)
> > > +{
> > > +	if (unlikely(!audit_dummy_context())) {
> > 
> > I've always hated these likely/unlikely. Mostly because I think
> > they
> > are so often wrong. I believe this says that you compiled audit in
> > but
> > you expect it to be explicitly disabled. While that is (recently)
> > true
> > in Fedora I highly doubt that's true on the vast majority of
> > systems
> > that have audit compiled in.
> 
> It has been argued that audit should have pretty much no performance
> impact if it is not in use and that if it is, we're willing to take
> the
> more significant overhead of the rest of the code for the sake of one
> test to determine whether or not to follow this code path.

Ok, I can buy that argument. Not sure its where I would have settled,
but it does make sense. I'll obviously defer to Paul on what he wants
out of style. I always assume the compiler is brilliant and write
stupid code but your logic is sound there too.

You can/should pretend I said nothing.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 11:00 +0100
  Re: [PATCH V2] audit: log 32-bit socketcalls Eric Paris <eparis@redhat.com> - 2017-01-13 15:50 +0100
    Re: [PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 16:10 +0100
      Re: [PATCH V2] audit: log 32-bit socketcalls Eric Paris <eparis@redhat.com> - 2017-01-13 16:20 +0100
        Re: [PATCH V2] audit: log 32-bit socketcalls Richard Guy Briggs <rgb@redhat.com> - 2017-01-13 16:30 +0100
  Re: [PATCH V2] audit: log 32-bit socketcalls David Miller <davem@davemloft.net> - 2017-01-16 19:40 +0100

csiph-web