Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559250

Re: Calling device_init_wakeup() on driver removal

Show all headers | View raw

On Saturday, January 14, 2017 08:46:05 PM Guenter Roeck wrote:
> Hi folks,

Hi,

> while looking through driver initialization and removal functions, I noticed that many drivers
> call device_init_wakeup(dev, false) in the removal function. Given that the driver is about
> to be removed, that doesn't make much sense to me, especially since device_wakeup_disable()
> is called from device_pm_remove() anyway.
> 
> Is it safe to assume that all those calls can be removed, or is there a possible reason for
> keeping them around ?

Removing them automatically might break things, because device_init_wakeup(dev, false)
also clears the power.can_wakeup flag and removes the "wakeup" attribute from sysfs.

I guess they could be removed safely in the majority of cases, though.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Calling device_init_wakeup() on driver removal Guenter Roeck <linux@roeck-us.net> - 2017-01-15 05:50 +0100
  Re: Calling device_init_wakeup() on driver removal "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-15 16:00 +0100
    Re: Calling device_init_wakeup() on driver removal Guenter Roeck <linux@roeck-us.net> - 2017-01-15 16:30 +0100

csiph-web