Calling device_init_wakeup() on driver removal

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Calling device_init_wakeup() on driver removal
Date	2017-01-15 05:50 +0100
Message-ID	<sZKVr-6yh-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi folks,

while looking through driver initialization and removal functions, I noticed that many drivers
call device_init_wakeup(dev, false) in the removal function. Given that the driver is about
to be removed, that doesn't make much sense to me, especially since device_wakeup_disable()
is called from device_pm_remove() anyway.

Is it safe to assume that all those calls can be removed, or is there a possible reason for
keeping them around ?

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Calling device_init_wakeup() on driver removal Guenter Roeck <linux@roeck-us.net> - 2017-01-15 05:50 +0100
  Re: Calling device_init_wakeup() on driver removal "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-01-15 16:00 +0100
    Re: Calling device_init_wakeup() on driver removal Guenter Roeck <linux@roeck-us.net> - 2017-01-15 16:30 +0100

csiph-web