Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1559031
| Path | csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | David Miller <davem@davemloft.net> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] cxgb4: Remove redundant memset before memcpy |
| Date | Sat, 14 Jan 2017 18:10:02 +0100 |
| Message-ID | <sZA02-8F-23@gated-at.bofh.it> (permalink) |
| References | <sZlaG-86Y-3@gated-at.bofh.it> |
| X-Original-To | mayhs11saini@gmail.com |
| X-Mailer | Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) |
| MIME-Version | 1.0 |
| Content-Type | Text/Plain; charset=us-ascii |
| Content-Transfer-Encoding | 7bit |
| X-Greylist | Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 14 Jan 2017 08:01:27 -0800 (PST) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 13 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | hariprasad@chelsio.com, tklauser@distanz.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Sat, 14 Jan 2017 12:00:27 -0500 (EST) |
| X-Original-Message-ID | <20170114.120027.401686898931069481.davem@davemloft.net> |
| X-Original-References | <1484356660-19082-1-git-send-email-mayhs11saini@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1559031 |
Show key headers only | View raw
From: Shyam Saini <mayhs11saini@gmail.com> Date: Sat, 14 Jan 2017 06:47:40 +0530 > The region set by the call to memset, immediately overwritten by > the subsequent call to memcpy and thus makes the memset redundant. > > Also remove the memset((&info, 0, sizeof(info)) on line 398 because > info is memcpy()'ed to before being used in the loop and it isn't > used outside of the loop. > > Signed-off-by: Shyam Saini <mayhs11saini@gmail.com> Applied to net-next, thanks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] cxgb4: Remove redundant memset before memcpy Shyam Saini <mayhs11saini@gmail.com> - 2017-01-14 02:20 +0100 Re: [PATCH] cxgb4: Remove redundant memset before memcpy Tobias Klauser <tklauser@distanz.ch> - 2017-01-14 13:30 +0100 Re: [PATCH] cxgb4: Remove redundant memset before memcpy David Miller <davem@davemloft.net> - 2017-01-14 18:10 +0100
csiph-web