Re: [PATCH] cxgb4: Remove redundant memset before memcpy

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cxgb4: Remove redundant memset before memcpy
Date	2017-01-14 18:10 +0100
Message-ID	<sZA02-8F-23@gated-at.bofh.it> (permalink)
References	<sZlaG-86Y-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Shyam Saini <mayhs11saini@gmail.com>
Date: Sat, 14 Jan 2017 06:47:40 +0530

> The region set by the call to memset, immediately overwritten by
> the subsequent call to memcpy and thus makes the  memset redundant.
> 
> Also remove the memset((&info, 0, sizeof(info)) on line 398 because
> info is memcpy()'ed to before being used in the loop and it isn't
> used outside of the loop.
> 
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cxgb4:  Remove redundant memset before memcpy Shyam Saini <mayhs11saini@gmail.com> - 2017-01-14 02:20 +0100
  Re: [PATCH] cxgb4:  Remove redundant memset before memcpy Tobias Klauser <tklauser@distanz.ch> - 2017-01-14 13:30 +0100
  Re: [PATCH] cxgb4: Remove redundant memset before memcpy David Miller <davem@davemloft.net> - 2017-01-14 18:10 +0100

csiph-web