Re: [PATCH] arm64/mm: use phys_addr_t

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64/mm: use phys_addr_t
Date	2017-01-13 13:10 +0100
Message-ID	<sZ8Q9-HA-9@gated-at.bofh.it> (permalink)
References	<sZ3x7-5Sp-1@gated-at.bofh.it> <sZ8ds-dR-11@gated-at.bofh.it> <sZ8ds-dR-17@gated-at.bofh.it> <sZ8wN-kY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 13, 2017 at 11:45:54AM +0000, Mark Rutland wrote:
> On Fri, Jan 13, 2017 at 11:27:48AM +0000, Ard Biesheuvel wrote:
> > On 13 January 2017 at 11:22, Mark Rutland <mark.rutland@arm.com> wrote:
> > > On Fri, Jan 13, 2017 at 01:59:35PM +0800, miles.chen@mediatek.com wrote:
> > >> From: Miles Chen <miles.chen@mediatek.com>
> > >>
> > >> Use phys_addr_t instead of unsigned long for the
> > >> return value of __pa(), make code easy to understand.
> > >>
> > >> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> > >
> > > This looks sensible to me. It's consistent with the types these
> > > variables are compared against, and with the types of function
> > > parameters these are passed as.
> > >
> > 
> > Indeed. But doesn't it clash with Laura's series?
> 
> Good point.
> 
> Yes, but only for the RHS of the assignment changing. This'll need to be
> rebased atop of the arm64 for-next/core branch, or Catalin/Will might
> fix it up when applying, perhaps?

Yeah, it's dead easy for me to fix up.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] arm64/mm: use phys_addr_t <miles.chen@mediatek.com> - 2017-01-13 07:30 +0100
  Re: [PATCH] arm64/mm: use phys_addr_t Catalin Marinas <catalin.marinas@arm.com> - 2017-01-13 12:20 +0100
  Re: [PATCH] arm64/mm: use phys_addr_t Mark Rutland <mark.rutland@arm.com> - 2017-01-13 12:30 +0100
    Re: [PATCH] arm64/mm: use phys_addr_t Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-01-13 12:30 +0100
      Re: [PATCH] arm64/mm: use phys_addr_t Mark Rutland <mark.rutland@arm.com> - 2017-01-13 12:50 +0100
        Re: [PATCH] arm64/mm: use phys_addr_t Will Deacon <will.deacon@arm.com> - 2017-01-13 13:10 +0100

csiph-web