Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1558237

Re: [PATCH] arm64/mm: use phys_addr_t

Show all headers | View raw

On Fri, Jan 13, 2017 at 01:59:35PM +0800, miles.chen@mediatek.com wrote:
> From: Miles Chen <miles.chen@mediatek.com>
> 
> Use phys_addr_t instead of unsigned long for the
> return value of __pa(), make code easy to understand.
> 
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> ---
>  arch/arm64/mm/mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 17243e4..7eb7c21 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -359,8 +359,8 @@ static void create_mapping_late(phys_addr_t phys, unsigned long virt,
>  
>  static void __init __map_memblock(pgd_t *pgd, phys_addr_t start, phys_addr_t end)
>  {
> -	unsigned long kernel_start = __pa(_text);
> -	unsigned long kernel_end = __pa(__init_begin);
> +	phys_addr_t kernel_start = __pa(_text);
> +	phys_addr_t kernel_end = __pa(__init_begin);

Looks fine.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] arm64/mm: use phys_addr_t <miles.chen@mediatek.com> - 2017-01-13 07:30 +0100
  Re: [PATCH] arm64/mm: use phys_addr_t Catalin Marinas <catalin.marinas@arm.com> - 2017-01-13 12:20 +0100
  Re: [PATCH] arm64/mm: use phys_addr_t Mark Rutland <mark.rutland@arm.com> - 2017-01-13 12:30 +0100
    Re: [PATCH] arm64/mm: use phys_addr_t Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-01-13 12:30 +0100
      Re: [PATCH] arm64/mm: use phys_addr_t Mark Rutland <mark.rutland@arm.com> - 2017-01-13 12:50 +0100
        Re: [PATCH] arm64/mm: use phys_addr_t Will Deacon <will.deacon@arm.com> - 2017-01-13 13:10 +0100

csiph-web