Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying.

From	Petr Mladek <pmladek@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying.
Date	2017-01-13 12:20 +0100
Message-ID	<sZ83M-ay-27@gated-at.bofh.it> (permalink)
References	(5 earlier) <sSBNf-4du-21@gated-at.bofh.it> <sSBNf-4du-9@gated-at.bofh.it> <sYNsm-4qh-29@gated-at.bofh.it> <sZ0fT-3DU-5@gated-at.bofh.it> <sZ1bY-4iU-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 2017-01-13 12:53:07, Sergey Senozhatsky wrote:
> On (01/13/17 11:52), Sergey Senozhatsky wrote:
> [..]
> > and we really don't want to cond_resched() when we are in panic.
> > that's why console_flush_on_panic() sets it to zero explicitly.
> > 
> > console_trylock() checks oops_in_progress, so re-taking the semaphore
> > when we are in
> > 
> > 	panic()
> > 	 console_flush_on_panic()
> >           console_unlock()
> >            console_trylock()
> > 
> > should be OK. as well as doing get_console_conditional_schedule() somewhere
> > in console driver code.
> 
> d'oh... no, this is false. console_flush_on_panic() is called after we
> bust_spinlocks(0), BUT with local IRQs disabled. so console_trylock()
> would still set console_may_schedule to 0.

Ah, you found it yourself.

Best Regards,
Petr

Thread

Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying. Petr Mladek <pmladek@suse.com> - 2017-01-12 14:20 +0100
  Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying. Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-01-13 04:00 +0100
    Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying. Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-01-13 05:00 +0100
      Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying. Petr Mladek <pmladek@suse.com> - 2017-01-13 12:20 +0100
    Re: [PATCH] mm/page_alloc: Wait for oom_lock before retrying. Petr Mladek <pmladek@suse.com> - 2017-01-13 12:20 +0100

csiph-web