Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1556980

Re: [PATCH 02/18] mtd-cfi_cmdset_0001: Improve another size determination in cfi_intelext_partition_fixup()

Show all headers | View raw

On 01/11/2017 09:37 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 10 Jan 2017 19:09:58 +0100

Please drop this stuff ^^^^^ git send-email should do that for you.

> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/mtd/chips/cfi_cmdset_0001.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
> index 68227aa74d22..0d7c2ef533d1 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0001.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
> @@ -753,7 +753,7 @@ static int cfi_intelext_partition_fixup(struct mtd_info *mtd,
>  			kfree(newcfi);
>  			return -ENOMEM;
>  		}
> -		memcpy(newcfi, cfi, sizeof(struct cfi_private));
> +		memcpy(newcfi, cfi, sizeof(*cfi));
>  		newcfi->numchips = numvirtchips;
>  		newcfi->chipshift = partshift;
>  
> 


-- 
Best regards,
Marek Vasut

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 02/18] mtd-cfi_cmdset_0001: Improve another size determination  in cfi_intelext_partition_fixup() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-11 21:40 +0100
  Re: [PATCH 02/18] mtd-cfi_cmdset_0001: Improve another size  determination in cfi_intelext_partition_fixup() Marek Vasut <marek.vasut@gmail.com> - 2017-01-11 23:10 +0100

csiph-web