Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc

From	Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc
Date	2017-01-12 23:40 +0100
Message-ID	<sYWch-196-3@gated-at.bofh.it> (permalink)
References	<sXBMB-zF-21@gated-at.bofh.it> <sXGjg-3xT-9@gated-at.bofh.it> <sYUWR-tD-5@gated-at.bofh.it> <sYW2C-15S-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 12, 2017 at 04:24:50PM -0600, lkml@pengaru.com wrote:
> On Thu, Jan 12, 2017 at 09:17:06PM +0000, Chris Wilson wrote:
> > On Mon, Jan 09, 2017 at 11:19:32AM +0000, Chris Wilson wrote:
> > > On a non-llc system, the objects are created with .cache_level =
> > > CACHE_NONE and so the transition to uncached for scanout is a no-op.
> > > However, if the object was never written to, it will still be in the CPU
> > > domain (having been zeroed out by shmemfs). Those cachelines need to be
> > > flushed prior to display.
> > > 
> > > Reported-by: Vito Caputo
> > > Fixes: a6a7cc4b7db6 ("drm/i915: Always flush the dirty CPU cache when pinning the scanout")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: <drm-intel-fixes@lists.freedesktop.org> # v4.10-rc1+
> > 
> > Ping?
> 
> This patch fixes the problem for me, in case that's what the ping's for.

Partly that, and trying to catch CI + reviewers.
 
> Out of curiosity the bug I reported described here be getting fixed in 4.10?
> https://lists.freedesktop.org/archives/dri-devel/2017-January/128405.html

It was fixed in the tree back in December, bit of a muddle to get that
particular patch into 4.10.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

BUG: 4.10 i915 drm display noise regression - bisected to a6a7cc4b7 lkml@pengaru.com - 2017-01-09 07:40 +0100
  [PATCH] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 11:30 +0100
    Re: [PATCH] drm/i915: Flush untouched framebuffers before display on  !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 12:00 +0100
  [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 12:30 +0100
    Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display  on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-12 22:20 +0100
      Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display  on !llc lkml@pengaru.com - 2017-01-12 23:30 +0100
        Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display  on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-12 23:40 +0100

csiph-web