Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1554229
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc |
| Date | 2017-01-09 12:30 +0100 |
| Message-ID | <sXGjg-3xT-9@gated-at.bofh.it> (permalink) |
| References | <sXBMB-zF-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On a non-llc system, the objects are created with .cache_level =
CACHE_NONE and so the transition to uncached for scanout is a no-op.
However, if the object was never written to, it will still be in the CPU
domain (having been zeroed out by shmemfs). Those cachelines need to be
flushed prior to display.
Reported-by: Vito Caputo
Fixes: a6a7cc4b7db6 ("drm/i915: Always flush the dirty CPU cache when pinning the scanout")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: <drm-intel-fixes@lists.freedesktop.org> # v4.10-rc1+
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 76689b59fc90..bdb113ef8cfe 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -3514,7 +3514,7 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,
vma->display_alignment = max_t(u64, vma->display_alignment, alignment);
/* Treat this as an end-of-frame, like intel_user_framebuffer_dirty() */
- if (obj->cache_dirty) {
+ if (obj->cache_dirty || obj->base.write_domain == I915_GEM_DOMAIN_CPU) {
i915_gem_clflush_object(obj, true);
intel_fb_obj_flush(obj, false, ORIGIN_DIRTYFB);
}
--
2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
BUG: 4.10 i915 drm display noise regression - bisected to a6a7cc4b7 lkml@pengaru.com - 2017-01-09 07:40 +0100
[PATCH] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 11:30 +0100
Re: [PATCH] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 12:00 +0100
[PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-09 12:30 +0100
Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-12 22:20 +0100
Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc lkml@pengaru.com - 2017-01-12 23:30 +0100
Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-12 23:40 +0100
csiph-web