Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1557730
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function |
| Date | Thu, 12 Jan 2017 20:00:01 +0100 |
| Message-ID | <sYSLn-7sp-7@gated-at.bofh.it> (permalink) |
| References | <sYS8G-7eZ-1@gated-at.bofh.it> |
| X-Original-To | "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> |
| Dkim-Signature | v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=931tjJguT9w4dmE5DTR5OX7XVOpmbVCGavseSTRRJ/A=; b=4ZSSoS+GCdjODZHZr8xAdVDuUOE/iuOY1D224um9WuiCMBKdGZYBdYAHI0Nw3xDwtKsupoO4VCLHtdf4vERlxEIB3jfFMQ2CvdXkV+d8xmpFpf5stfqy/Sa4cfNVIxi3EddLw6YnTV8rls8W5qSr6kmAq0qUeZ7B2LPtMJg+j/Q=; |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.24 (2015-08-30) |
| X-Broken-Reverse-Dns | no host name found for IP address 10.0.0.156 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 22 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | tpmdd-devel@lists.sourceforge.net, linux-kernel <linux-kernel@vger.kernel.org>, Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>, Christophe Ricard <christophe.ricard@gmail.com> |
| X-Original-Date | Thu, 12 Jan 2017 11:50:05 -0700 |
| X-Original-Message-ID | <20170112185005.GC12836@obsidianresearch.com> |
| X-Original-References | <6bd0d2fe-f979-a4dc-7c4d-54036f4d37f8@maciej.szmigiero.name> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1557730 |
Show key headers only | View raw
On Thu, Jan 12, 2017 at 07:12:06PM +0100, Maciej S. Szmigiero wrote:
> probe_itpm() function is supposed to send command without an itpm flag set
> and if this fails to repeat it, this time with the itpm flag set.
>
> However, commit 41a5e1cf1fe15 ("tpm/tpm_tis: Split tpm_tis driver into a
> core and TCG TIS compliant phy") moved the itpm flag from an "itpm"
> variable to a TPM_TIS_ITPM_POSSIBLE chip flag, so setting the
> (now function-local) itpm variable no longer had any effect.
>
> Finally, this function-local itpm variable was removed by
> commit 56af322156dbe9 ("tpm/tpm_tis: remove unused itpm variable")
>
> Tested only on non-iTPM TIS TPM.
>
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
could you also change the name of TPM_TIS_ITPM_POSSIBLE
to TPM_TIS_ITPM_WORKAROUND ?
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Jason
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] tpm_tis: fix iTPM probe via probe_itpm() function "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 19:20 +0100
Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-12 20:00 +0100
Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 21:20 +0100
Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-12 21:30 +0100
csiph-web