Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557730

Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function

Show all headers | View raw

On Thu, Jan 12, 2017 at 07:12:06PM +0100, Maciej S. Szmigiero wrote:
> probe_itpm() function is supposed to send command without an itpm flag set
> and if this fails to repeat it, this time with the itpm flag set.
> 
> However, commit 41a5e1cf1fe15 ("tpm/tpm_tis: Split tpm_tis driver into a
> core and TCG TIS compliant phy") moved the itpm flag from an "itpm"
> variable to a TPM_TIS_ITPM_POSSIBLE chip flag, so setting the
> (now function-local) itpm variable no longer had any effect.
> 
> Finally, this function-local itpm variable was removed by
> commit 56af322156dbe9 ("tpm/tpm_tis: remove unused itpm variable")
> 
> Tested only on non-iTPM TIS TPM.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>

could you also change the name of TPM_TIS_ITPM_POSSIBLE
to TPM_TIS_ITPM_WORKAROUND ?

Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm_tis: fix iTPM probe via probe_itpm() function "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 19:20 +0100
  Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-12 20:00 +0100
    Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> - 2017-01-12 21:20 +0100
  Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-12 21:30 +0100

csiph-web