Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1557580

Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h
Date 2017-01-12 17:30 +0100
Message-ID <sYQqe-69X-33@gated-at.bofh.it> (permalink)
References <sYNsn-4qh-49@gated-at.bofh.it> <sYMcV-3w1-3@gated-at.bofh.it> <sYOy5-52g-7@gated-at.bofh.it> <sYPNw-5HL-15@gated-at.bofh.it> <sYQgy-66R-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 12, 2017 at 5:14 PM, David Howells <dhowells@redhat.com> wrote:
>> >         reply.ia.uuid[3] = htonl((s8) afs_uuid.clock_seq_hi_and_reserved);
>> >         reply.ia.uuid[4] = htonl((s8) afs_uuid.clock_seq_low);
>> >         for (loop = 0; loop < 6; loop++)
>>
>> Shouldn't this be ntohs() instead of ntohl(), like this:
>>
>>        reply.ia.uuid[1] = htonl(ntohl(afs_uuid.time_mid));
>>        reply.ia.uuid[2] = htonl(ntohl(afs_uuid.time_hi_and_version));
>
> I think you forgot to change ntohl() to ntohs() in that - and you're right.
>
> Okay, how about the attached?

Yes, looks good to me.

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] afs: Move UUID struct to linux/uuid.h David Howells <dhowells@redhat.com> - 2017-01-12 13:00 +0100
  [PATCH 2/2] afs: Use core kernel UUID generation David Howells <dhowells@redhat.com> - 2017-01-12 13:00 +0100
  Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h Arnd Bergmann <arnd@arndb.de> - 2017-01-12 14:20 +0100
    Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h David Howells <dhowells@redhat.com> - 2017-01-12 15:30 +0100
      Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h Arnd Bergmann <arnd@arndb.de> - 2017-01-12 16:50 +0100
        Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h David Howells <dhowells@redhat.com> - 2017-01-12 17:20 +0100
          Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h Arnd Bergmann <arnd@arndb.de> - 2017-01-12 17:30 +0100
            Re: [PATCH 1/2] afs: Move UUID struct to linux/uuid.h David Howells <dhowells@redhat.com> - 2017-01-12 17:50 +0100

csiph-web