Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1555093

Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted __le16

Show all headers | View raw

On Mon, 9 Jan 2017 21:25:56 -0600
Eric Salem <ericsalem@gmail.com> wrote:

> Fixed the following sparse warning:
> 
> drivers/staging/most/hdm-usb/hdm_usb.c:158:16: warning:
> cast to restricted __le16
> 
> by correcting the variable's type (also updated sizeof).
> 
> Signed-off-by: Eric Salem <ericsalem@gmail.com>

Acked-by: Christian Gromm <christian.gromm@microchip.com>

> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
> index d6db0bd..01e3a31 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -145,7 +145,7 @@ static void wq_netinfo(struct work_struct *wq_obj);
>  static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
>  {
>  	int retval;
> -	u16 *dma_buf = kzalloc(sizeof(u16), GFP_KERNEL);
> +	__le16 *dma_buf = kzalloc(sizeof(*dma_buf), GFP_KERNEL);
>  	u8 req_type = USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE;
>  
>  	if (!dma_buf)
> @@ -154,7 +154,7 @@ static inline int drci_rd_reg(struct usb_device *dev, u16 reg, u16 *buf)
>  	retval = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0),
>  				 DRCI_READ_REQ, req_type,
>  				 0x0000,
> -				 reg, dma_buf, sizeof(u16), 5 * HZ);
> +				 reg, dma_buf, sizeof(*dma_buf), 5 * HZ);
>  	*buf = le16_to_cpu(*dma_buf);
>  	kfree(dma_buf);
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: most: hdm-usb: Fix sparse warning cast to restricted  __le16 Eric Salem <ericsalem@gmail.com> - 2017-01-10 04:30 +0100
  Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to  restricted __le16 Christian Gromm <christian.gromm@microchip.com> - 2017-01-10 10:50 +0100
  Re: [PATCH] staging: most: hdm-usb: Fix sparse warning cast to  restricted __le16 Greg KH <gregkh@linuxfoundation.org> - 2017-01-10 17:50 +0100
    [PATCH v2] staging: most: hdm-usb: Fix mismatch between types used in  sizeof operator Eric Salem <ericsalem@gmail.com> - 2017-01-11 02:40 +0100

csiph-web