Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

From	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly
Date	2017-01-10 10:00 +0100
Message-ID	<sY0rE-7yf-21@gated-at.bofh.it> (permalink)
References	<sMbst-Yb-9@gated-at.bofh.it> <sMbst-Yb-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 08 December 2016 11:38 PM, Josh Poimboeuf wrote:
> The _TIF_ALLWORK_MASK macro automatically includes the least-significant
> 16 bits of the thread_info flags, which is less than obvious and tends
> to create confusion and surprises when reading or modifying the code.
>
> Define the flags explicitly.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

For the version with swapped _TIF_SINGLESTEP and _TIF_NEED_RESCHED
flags.

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

-- 
cheers,
Kamalesh.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags  explicitly Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> - 2017-01-10 10:00 +0100

csiph-web