[PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement.

From	Chris Lapa <chris@lapa.com.au>
Newsgroups	linux.kernel
Subject	[PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement.
Date	2017-01-09 01:50 +0100
Message-ID	<sXwjT-5mL-7@gated-at.bofh.it> (permalink)
References	<sR0mJ-2AR-5@gated-at.bofh.it> <sXwjT-5mL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Chris Lapa <chris@lapa.com.au>

This is done for readability as the upcoming commits will add a lot of
cases.

tested: no

Signed-off-by: Chris Lapa <chris@lapa.com.au>
---
 drivers/power/supply/bq27xxx_battery.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index 3b0dbc6..fd4cc4e 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -635,12 +635,17 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di)
  */
 static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags)
 {
-	if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545)
+	switch (di->chip) {
+	case BQ27500:
+	case BQ27541:
+	case BQ27545:
 		return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
-	if (di->chip == BQ27530 || di->chip == BQ27421)
+	case BQ27530:
+	case BQ27421:
 		return flags & BQ27XXX_FLAG_OT;
-
-	return false;
+	default:
+		return false;
+	}
 }
 
 /*
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement. Chris Lapa <chris@lapa.com.au> - 2017-01-09 01:50 +0100
  Re: [PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to  a switch statement. "Andrew F. Davis" <afd@ti.com> - 2017-01-09 16:40 +0100

csiph-web