Path: csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod From: Chris Lapa Newsgroups: linux.kernel Subject: [PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement. Date: Mon, 09 Jan 2017 01:50:01 +0100 Message-ID: References: Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lapa-com-au.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iZ80koAE8L+bIKf3UGzoXIRdueo8wrhM4EINtVkXMYI=; b=BuMQiUpvHm67DLSfLhNAC3CfjRUUP95VtvFprO6eOE693ki5kpXWXusahHQLZt3fe8 d/SQZafOSc6vR1Rr0gDYuechNz925yG8sPz6orfMMFbO8RX8WA/IdRgKF34esod1JVe8 S5yll9aXv/F9ZrXFtfU6nVjGNObqK3Rx+0vsamka241MhZe+EE283LSHI0Vou+bYiAH4 oIkbKvdWmsrf+8WPC2UqGZ19FYaf73qjI35fQN/V3dmcCFkcBNPsYoZNQb0cuTVnxVus /gS431BCv1YGL7lbG2ueZq5mXDiNc15ESiysFUH/sD0EgtyssDMeW1CgJ4cdRSETqzBD 5Ecw== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iZ80koAE8L+bIKf3UGzoXIRdueo8wrhM4EINtVkXMYI=; b=XIf6sy2B40d24tNhAsCGZfjpvNr6mEZmg08W+XXHP9tZHmRvCqeX6H3D71N09aJYC/ Wop12WjYGksep4v9ATwE1+UT7F1FrLq49h1D3jSTmdjovQQipz+DWpp5++fBT6VZzT6Q ruFZQGDf0rdgEcEdxLgFgcdp0LeV4d0g9+8CIon235uW4kM3kIG80DLv4NhINK4om6bf Xf3Vrq7QzHSiRboC4J0mWDxF5RNbwbjF1xaO8SDVL1+OTg5blN5m9LSDO+wueH17uswD EDRXPUqc1QSBF87xzsVccpsZfwwnCLXp1yhl+9k9rJ6cJGoz0zfUlu4HwAE2ARxwtlnr 6D7g== X-Gm-Message-State: AIkVDXLk3kT5EkB1Z1yY3o1r+kpA3mO7gmcIWhDSxXwbhD9DEJmQF9uFLMtkUM3thROFmA== X-Received: by 10.99.110.74 with SMTP id j71mr26656010pgc.134.1483922874259; Sun, 08 Jan 2017 16:47:54 -0800 (PST) X-Google-Original-From: Chris Lapa X-Mailer: git-send-email 2.1.4 Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 40 Organization: linux.* mail to news gateway X-Original-Cc: Chris Lapa X-Original-Date: Mon, 9 Jan 2017 11:47:35 +1100 X-Original-Message-ID: <1483922865-96321-2-git-send-email-chris@lapa.com.au> X-Original-References: <1482369743-79764-1-git-send-email-chris@lapa.com.au> <1483922865-96321-1-git-send-email-chris@lapa.com.au> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1553988 From: Chris Lapa This is done for readability as the upcoming commits will add a lot of cases. tested: no Signed-off-by: Chris Lapa --- drivers/power/supply/bq27xxx_battery.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c index 3b0dbc6..fd4cc4e 100644 --- a/drivers/power/supply/bq27xxx_battery.c +++ b/drivers/power/supply/bq27xxx_battery.c @@ -635,12 +635,17 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di) */ static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags) { - if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545) + switch (di->chip) { + case BQ27500: + case BQ27541: + case BQ27545: return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD); - if (di->chip == BQ27530 || di->chip == BQ27421) + case BQ27530: + case BQ27421: return flags & BQ27XXX_FLAG_OT; - - return false; + default: + return false; + } } /* -- 2.1.4