Re: [PATCH 2/4] watchdog: coh901327_wdt: Keep clock enabled after loading driver

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] watchdog: coh901327_wdt: Keep clock enabled after loading driver
Date	2017-01-09 20:40 +0100
Message-ID	<sXNXs-8fG-25@gated-at.bofh.it> (permalink)
References	<sVKqZ-7ps-5@gated-at.bofh.it> <sVKqZ-7ps-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 4, 2017 at 4:25 AM, Guenter Roeck <linux@roeck-us.net> wrote:

> Enabling the clock before accessing chip registers and disabling it
> afterwards does not really make sense and only adds complexity to
> the driver. In addition to that, a comment int the driver suggests
> that it does not serve a useful purpose either.
>
> "The watchdog block is of course always clocked, the
>  clk_enable()/clk_disable() calls are mainly for performing reference
>  counting higher up in the clock hierarchy."
>
> Just keep the clock enabled instead.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] watchdog: coh901327_wdt: Keep clock enabled after loading driver Guenter Roeck <linux@roeck-us.net> - 2017-01-04 04:30 +0100
  Re: [PATCH 2/4] watchdog: coh901327_wdt: Keep clock enabled after  loading driver Linus Walleij <linus.walleij@linaro.org> - 2017-01-09 20:40 +0100

csiph-web